Merged
Conversation
Contributor
|
@ShogunPanda I would not call the interface Enum. Maybe |
Contributor
Author
|
Done, what about now? |
Contributor
|
I dont know how strict you want your IntDict to actually be. This is when you want them to be more strict. Typescript Playground Thats why I wrote, that you would basically duplicate the code, once as an interface and once for the the Object. But this is just fyi. If you like it more strict, than this is the way to go. Or maybe not. Your decision ;). |
Contributor
Author
|
Since we use them internally (as llhttp it not published anymore on NPM) I don't it cares too much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Uzlopak I had to remove
-rin the test run script to avoid starting a REPL locally. Was yours a leftover or am I missing someting?